sea: support ESM entry point in SEA#61813
Conversation
|
Review requested:
|
| The `node:sea` builtin allows interaction with the single-executable application | ||
| from the JavaScript main script embedded into the executable. | ||
|
|
||
| #### `sea.isSea()` |
There was a problem hiding this comment.
Drive-by: fixed this since it seems out of touch with other APIs below.
This uses the new StartExecutionCallbackWithModule embedder API to support ESM entrypoint in SEA via a new configuration field `"mainFormat"`. The behavior currently aligns with the embedder API and is mostly in sync with the CommonJS entry point behavior, except that support for code caching and snapshot is left for follow-ups.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61813 +/- ##
==========================================
+ Coverage 89.74% 89.76% +0.02%
==========================================
Files 675 675
Lines 204735 204775 +40
Branches 39348 39351 +3
==========================================
+ Hits 183737 183821 +84
+ Misses 13269 13225 -44
Partials 7729 7729
🚀 New features to boost your workflow:
|
targos
left a comment
There was a problem hiding this comment.
RSLGTM on the C++.
I tested the PR on an existing app and it works well, thanks!
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
|
Landed in af0d6d4 |
This uses the new StartExecutionCallbackWithModule embedder API added in #61548 to support ESM entrypoint in SEA via a new configuration field
"mainFormat". The behavior currently aligns with the embedder API and is mostly in sync with the CommonJS entry point behavior, except that support for code caching and snapshot is left for follow-ups.Note: for follow-ups: